fossasia / pslab-webapp

PSLab Web App https://pslab.io
Apache License 2.0
1.48k stars 42 forks source link

Add a tab to show the source code snippet in the execute modal. Adding API reference. #78

Closed jithinbp closed 7 years ago

jithinbp commented 7 years ago


psl_virt_apidocs

jithinbp commented 7 years ago

@niranjan94 the build failed because an eslint rule prohibits nested interactives

error Do not use <button> inside an element withrole="tabpanel"nested-interactive

Googling isn't turning up any pointers. Why is this prohibited? Does this mean tabs cannot have any interactive matter like buttons, textarea, sliders etc?

jithinbp commented 7 years ago

@niranjan94 I've still got nothing on why It's not allowed. Is there an eslint rule I can override, or should I close this PR and implement the show-source feature as a toggle or something (Even that is probably a case of nested-interactive ) ?

niranjan94 commented 7 years ago

Rule reference:

For now, remove role="tabpanel"

jithinbp commented 7 years ago

@niranjan94 please merge this. I took care of the eslint issue.

I also included the following in this PR: