No option to search videos

[vaibhavsingh97]

With reference to #58

I'm submitting a ...

• [ ] bug report
• [x] feature request

Current behavior: There is no option to search videos in Search engines

Expected behavior: There should be option to search videos

Open To claim

[raju249]

@vaibhavsingh97 ,

I can take this up if you are busy with something else :smile: let me know what you think ?

[vaibhavsingh97]

@raju249 Are you working on the issue?

[umangahuja1]

Assign this issue to me since nobody is working as of now and I am willing to take this up. @vaibhavsingh97

[vaibhavsingh97]

@umangahuja1 I can't assign the issue to you but you can work on this issue. Thanks

[umangahuja1]

Okay since you said to get assigned but I don't know how to do it. I am starting it then.

Just for confirmation, this feature intend to get these title and url from videos section?

Like https://www.icc-cricket.com/womens-world-cup/video/440702 for the first item.

[vaibhavsingh97]

Yes @umangahuja1 So what we discussed in gitter to have one extra attribute type which contains url, image and video and based on the type and format. result will be displayed.

[umangahuja1]

Great so for now I will start will google, but I think this will be done for all those search engines that offer images and videos.

So most probably all the changes will be made in their respective files (e.g for google google.py) and other functions will be added to scrape accordingly.

Is this what you are doing in image feature?

[bhaveshAn]

@umangahuja1 Since this issue has been taken too long, without any progress, so please work on this a little quick, with regular update as this need regular discussions on the approach.

Also, I have fixed half of it. So if you aren't fully comfortable with the approach then let me make a pull on Video search in 3-4 days or so. and then you can switch to other file types like Image search etc (As the approach will be same for both the searches). I think it would be better.

[umangahuja1]

What have you done, if anything? Because it's not a bug, it's a feature so there is nothing to be fixed I suppose.

Better to discuss in chat or wherever with others too if you have done something because I took it today itself. Switch to gitter.

[bhaveshAn]

All I mean I am about to give the PR on this in 3-4 days. So please don't work on this. @vaibhavsingh97 You can assign it to me as this is definitely not a beginners issue, advanced one as all the enhancement on all the supported search engines. And @umangahuja1 Please start the project from some beginners issue. Or check if https://github.com/fossasia/query-server/issues/321 is available as it is also not assigned. Maybe you can take #368 #265

[vaibhavsingh97]

@bhaveshAn IMO, i think @umangahuja1 should get a fair chance. Let him try. I know it's not an beginner issue but what's wrong in giving a chance. we can help him if he got stuck somewhere. It's good that you want to work on this issue but @umangahuja1 asked to claim first so h should get the fair chance. Thanks

[harshit98]

@bhaveshAn @vaibhavsingh97 What's the matter?

@umangahuja1 Hi. You may please proceed to solve this issue and take your time. If you need any help, chat is the best way to communicate!

[umangahuja1]

Here is the screenshot of video feature

I will add front end and will send a PR soon.

[Remorax]

@vaibhavsingh97 @umangahuja1 @harshit98 Can I work on the other search engines? It would be better if the work is divided, right?

[umangahuja1]

I think that will be a great idea. I am working on bing so you can choose any other. We can pace up things this way. But for that it would be better to merge the PR I sent since it will be used in all other engined.

What do you all say?

[Remorax]

That's cool @umangahuja1 😄 I'll be making a PR within the next 2 days 😄

[umangahuja1]

Wait let the google search PR get merged since it has front end part. Also generalised.py and one more file has some changes that will be used in all.

[bhaveshAn]

Okay, so I will also be working for video search in Baidu and Ask.

On Jan 14, 2018 1:46 PM, "Umang Ahuja" notifications@github.com wrote:

Wait let the google search PR get merged since it has front end part. Also generalised.py and one more file has some changes that will be used in all.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fossasia/query-server/issues/320#issuecomment-357495695, or mute the thread https://github.com/notifications/unsubscribe-auth/AV37-s1oLKdsSE1tXrc671VqWbE9xJF4ks5tKbf4gaJpZM4QWvq7 .

[Remorax]

Cool, I'll be working on Yahoo and DuckDuckGo.

[Remorax]

@umangahuja1 Sure we'll wait for your PR to get merged, don't worry 😄 . Okay @bhaveshAn ?

[Remorax]

@bhaveshAn Let's divide the work. I'll be working on Mojeek, Ask and DuckDuckGo. Can you work on the rest? Thanks 😄

[bhaveshAn]

Mojeek is not supporting Image/Video search check it out https://www.mojeek.co.uk/search?q=fossasia I am working on Ask Video search as claimed previously https://github.com/fossasia/query-server/issues/320#issuecomment-357495815

You can proceed with Duckduckgo

[Remorax]

@bhaveshAn you had claimed Baidu and Ask but you made PRs for Parsijoo and Bing 😛 I was actually in the middle of working on Bing, so idk what to say to that. But yeah, I'll work on DuckDuckGo then.

[bhaveshAn]

Yeah, earlier, I had claimed Ask and Baidu, and you claimed Yahoo (For which made the PR) and Duckudckgo, but there was no discussion on Parsijoo and Bing, thats why I made the PR, suddenly, since no one here claimed rest out of Ask, Baidu Yahoo, DuckDuckGo

[Remorax]

That's true but you should probably have worked on Baidu and Ask first and then work on Bing and Parsijoo after asking others and making sure no one else is working on it. Peace 😄

[bhaveshAn]

@Remorax Would you like to take up Baidu ?? Then I would like to work on DuckDuckGo.

[bhaveshAn]

@Remorax reminder

[Remorax]

Oh, yeah sure @bhaveshAn work on DuckDuckGo and I'll work on Baidu 😄 And if anyone wants to work on any search engine, please post here and confirm whether somebody else is working on it or not, so as to not waste anybody's time. Thanks 😄