Closed ankan17 closed 6 years ago
I think you haven't updated the branch.
I last updated when I started working and not after that.. Looks like I have quite a lot of work on my hands now.. More functions to reduce :sweat_smile:
Merging #478 into master will decrease coverage by
4.16%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #478 +/- ##
==========================================
- Coverage 91.84% 87.68% -4.17%
==========================================
Files 30 28 -2
Lines 895 893 -2
==========================================
- Hits 822 783 -39
- Misses 73 110 +37
Impacted Files | Coverage Δ | |
---|---|---|
test/test_generalized.py | 97.14% <ø> (-0.73%) |
:arrow_down: |
test/test_bing.py | 100% <100%> (ø) |
:arrow_up: |
test/test_quora.py | 100% <100%> (ø) |
:arrow_up: |
test/test_google.py | 100% <100%> (ø) |
:arrow_up: |
app/scrapers/__init__.py | 89.28% <100%> (-6.72%) |
:arrow_down: |
test/test_parsijoo.py | 100% <100%> (ø) |
:arrow_up: |
test/test_youtube.py | 100% <100%> (ø) |
:arrow_up: |
test/test_mojeek.py | 100% <100%> (ø) |
:arrow_up: |
test/test_duckduckgo.py | 100% <100%> (ø) |
:arrow_up: |
test/test_baidu.py | 100% <100%> (ø) |
:arrow_up: |
... and 14 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 3f52d86...5d7631b. Read the comment docs.
Deployed at https://quiet-sea-69569.herokuapp.com/
@ParthS007 The PR was good yesterday and now it has conflicts -_-
@bhaveshAn The change you requested has been made. The deployment link is provided
Please resolve conflicts
@ankan17 Update please
Sorry for the delay.. I will resolve the conflicts ASAP
I am closing this pull request because the git history has diverged and I can't rebase my commits. I will make a fresh PR
Fixes #461
Checklist
master
branch.Changes proposed in this pull request:
The functionality of search_without_count has been implemented from the search method with a default count and the following changes have been made with regards to tests.
Three tests for each scraper has been added to test the search function with a popular search term "fossasia"
The test_search_without_count method has been removed from the test_generalized.py file