Closed Remorax closed 6 years ago
Merging #489 into master will increase coverage by
8.36%
. The diff coverage is90.32%
.
@@ Coverage Diff @@
## master #489 +/- ##
==========================================
+ Coverage 82.54% 90.91% +8.36%
==========================================
Files 29 29
Lines 957 881 -76
==========================================
+ Hits 790 801 +11
+ Misses 167 80 -87
Impacted Files | Coverage Δ | |
---|---|---|
app/scrapers/__init__.py | 96% <ø> (+13.14%) |
:arrow_up: |
app/scrapers/bing.py | 100% <100%> (ø) |
:arrow_up: |
test/test_bing.py | 100% <100%> (ø) |
:arrow_up: |
app/scrapers/generalized.py | 87.09% <72.72%> (+48.74%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cf912cc...ff99c34. Read the comment docs.
@ParthS007 I've resolved the merge conflicts but I did it using the GUI so can the latest commit be merged?
@bhaveshAn The link has been updated. Please check now.
I mean response is same whether I go for General search or News search. Just search for any keyword for General search and News search. You will get the same results. Go through these get requests and see the differences, if any. (No difference) General search : https://infinite-scrubland-15160.herokuapp.com/api/v1/search/bing?query=google&qtype=general&format=json News search : https://infinite-scrubland-15160.herokuapp.com/api/v1/search/bing?query=google&qtype=news&format=json
Addresses #468
Checklist
master
branch.Changes proposed in this pull request:
Link: https://evening-eyrie-95749.herokuapp.com/
@vaibhavsingh97 @ParthS007 @realslimshanky Please review 😄