Show password not working in login/register

fossasia / susi.ai

SUSI.AI Web Client https://susi.ai

GNU Lesser General Public License v2.1

2.05k stars 852 forks source link

Closed Tanuj22 closed 4 years ago

Tanuj22 commented 4 years ago

Actual Behaviour The show password eye in login/register is not working

Expected Behaviour The password should be visible when clicked upon

Steps to reproduce it Try to login/register

Screenshots of the issue

pass (online-video-cutter com)

Would you like to work on the issue?

Yes

Tanuj22 commented 4 years ago

@snitin315 Is this a valid issue?

snitin315 commented 4 years ago

Yes, feel free to fix it.

Tanuj22 commented 4 years ago

According to the docs this should be enabled by default. Is this an issue with the component itself?

amit2699 commented 4 years ago

@Tanuj22 Can I work on this issue #3578

26Vinayak commented 4 years ago

I am working on this issue. #3578

ShubhamChaudharyy commented 4 years ago

I am working on this issue. #3578

but i linked a pull request for this issue 4 days ago

ShubhamChaudharyy commented 4 years ago

According to the docs this should be enabled by default. Is this an issue with the component itself?

actually yes , the pre-installed package wasnt working.. I Linked a pull request can you check @Tanuj22

SingingApple commented 4 years ago

Pr #3608 fixed this issue!