search

fossasia / susi.ai

SUSI.AI Web Client https://susi.ai
GNU Lesser General Public License v2.1
2.04k stars 851 forks source link

npm test and npm run predeploy breaks for devs who donot have yarn installed globally #3612

Closed ashutoshc8101 closed 3 years ago

ashutoshc8101 commented 3 years ago

Actual Behaviour npm test and npm run predeploy throws error for developers who haven't installed yarn globally

Expected Behaviour npm test and npm run predeploy should work fine without having to install yarn globally

Steps to reproduce it git clone cd susi.ai npm install npm test || npm run predeploy

Screenshots of the issue Screenshot from 2020-12-10 17-29-56 npm run predeploy

Would you like to work on the issue? I would like make global installation of yarn optional to work on project for developers. I will add yarn to devDependencies in package.json. So tha dev have a local installation of yarn in project and npm test and npm run predeploy work fine after npm install command I will change test and predeploy scripts from yarn lint to yarn || npm lint so that if yarn is not installed script should run with npm

akshatnitd commented 3 years ago

@ashutoshc8101 Installing yarn is a part of the dev setup. We are trying to avoid usage of npm as compared to yarn, because of its multiple downsides and slowness.

ashutoshc8101 commented 3 years ago

@akshatnitd should i close this issue and associated PR ?

akshatnitd commented 3 years ago

@ashutoshc8101 Yes please