search

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi
Apache License 2.0
2.42k stars 1.11k forks source link

feat: Implement instrumentation test for device activity #2352

Closed atm1504 closed 5 years ago

atm1504 commented 5 years ago

Fixes #2351 2351

Changes: Added instrumentation test for device activity

Screenshots for the change: No relevant UI changes

iamareebjamal commented 5 years ago

What is an implementation test?

Also, this test is useless

atm1504 commented 5 years ago

What is an implementation test?

Also, this test is useless

I wrote implementation test by mistake. I have corrected it. When I went through the code base under the test section, I found an instrumentation test is present for every almost every activity. So, I added this test for the device activity, which was missing.

iamareebjamal commented 5 years ago

Instrumention tests are not even being run on CI. Because they are useless. They are not testing anything

atm1504 commented 5 years ago

Instrumention tests are not even being run on CI. Because they are useless. They are not testing anything

Should I remove it from other activities also? Similar tests are present there also.

iamareebjamal commented 5 years ago

Let them be. They're not getting executed

atm1504 commented 5 years ago

Okk, so I am closing this pr and the corresponding issue