search

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi
Apache License 2.0
2.42k stars 1.11k forks source link

style: Fixed UI of help fragment #2437

Closed pallav12 closed 4 years ago

pallav12 commented 4 years ago

Fixes #2436 Changes: Changed initial of answer height to 0dp and dynamically increasing when question is clicked, added animation, added dropdown icon

Screenshots for the change: Helpgif

atm1504 commented 4 years ago

@iamareebjamal do we really need these changes?

pallav12 commented 4 years ago

@atm1504 should I first share screenshots on gitter then create PR or creating PR with issue is fine? because with UI its hard to explain improvements without PR.

atm1504 commented 4 years ago

@atm1504 should I first share screenshots on gitter then create PR or creating PR with issue is fine? because with UI its hard to explain improvements without PR.

You need to have an issue for a pr. No need of discussion in the Gitter channel for simple PR's or issues. In the Gitter channel, we need to discuss major issues.

ci-reporter[bot] commented 4 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 1ad50f2a37ab96de19daeffe30774f1b2e3b33ad. Here's the output:

Run Tests
> Task :assemble UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for 1ad50f2 ##### `Run Tests` ``` > Task :assemble UP-TO-DATE ```
This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.