search

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi
Apache License 2.0
2.42k stars 1.11k forks source link

style: Updated skills UI #2442

Closed pallav12 closed 4 years ago

pallav12 commented 4 years ago

Fixes #2441 Changes: Added additional cards, Changed font style, Changed margin

Screenshots for the change:

SkillsNew

SkillNew1

GIF SkillsUpdatedgif

atm1504 commented 4 years ago

Share some screenshots that show the difference between the two states oft he app (Before and after changing code)

pallav12 commented 4 years ago

Before WhatsApp Image 2020-01-03 at 23 44 15 After SkillNew1

before WhatsApp Image 2020-01-03 at 23 44 14

after SkillsNew

pallav12 commented 4 years ago

Updated according to changes reviewed

ci-reporter[bot] commented 4 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 5e2fda06f7fb293a7137f7a1c6bb43081203412d. Here's the output:

Run Tests
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for 5e2fda0 ##### `Run Tests` ``` > Task :app:preBuild UP-TO-DATE ```
This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.
pallav12 commented 4 years ago

@mohitm15 it's a UI change... It looks more decent(to me) with it, I can close this if it's not adding value.

pallav12 commented 4 years ago

@atm1504 , @mohitm15 should I close this if it's not adding much value?

mohitm15 commented 4 years ago

@pallav12 sure Look for any good first issue if you wanted to start

Sent from my VIBE K6 Power using FastHub