feat: Recaptcha verification during signup

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi

Apache License 2.0

2.42k stars 1.11k forks source link

feat: Recaptcha verification during signup #2444

Open chanmol1999 opened 4 years ago

chanmol1999 commented 4 years ago

Fixes #2350

Changes: Add recaptcha during signup.

Screenshots for the change:

chanmol1999 commented 4 years ago

@atm1504 Please review

atm1504 commented 4 years ago

The screenshot you provided has been copied from #2360 Its a case of plagiarism.

chanmol1999 commented 4 years ago

@atm1504 I don't think this is a case of plagiarism. Although I have not used your screenshot but still if you feel that the screenshot has been copied from your pull request you could have asked me to do the required changes. Simply closing the pr without any valid reason is not under the guidelines of open source contributions. Also, you shouldn't favor pull request of other contributors These things are totally unexpected from mentor of the project in such a great organization.This has given me a lot of disappointment.I may not contribute to this project in the future if such things happen again. As far as I know this is an open source project and using someone's screenshot doesn't come under plagiarism. Please look into this @iamareebjamal and @mariobehling and ensure such things do not repeat in future with some other contributors. Thanks.

iamareebjamal commented 4 years ago

OK @atm1504 Why should copying your screenshot, or even your code be considered plagiarism? You contributed that as open source. Unless you have complete your PR, why shouldn't anyone else even use your code to do it? And here, it's not even code being copied. I don't think you understand plagiarism. Screenshot was not even required in the PR.

atm1504 commented 4 years ago

@iamareebjamal I don't consider copying code as plagiarism in open source. But the thing is that this pr was created without even testing the code, which can be proved directly by seeing the screenshot. Creating a pr without even testing it is a really bad habit. My point was that only. Also, the key he has provided is the same as that was supplied. Now, suppose that the key has expired for now, but he created the pr, claiming that he worked and the code executed properly (without even testing), is that a good habit. SHouldn't all this be checked properly?

iamareebjamal commented 4 years ago

You didn't write any of that. Only about screenshot being copied

atm1504 commented 4 years ago

@iamareebjamal that was my fault that I didn't mention all the reasons.

chanmol1999 commented 4 years ago

@atm1504 I checked it with my key but I thought that maybe the key you used previously was still active and is in current use. Also, You should have mentioned that before claiming plagiarism. And also I was already going to make changes as requested by @iamareebjamal Sir. And In that changes definitely this key is supposed to be removed. Please do mention things correctly before reaching to a conclusion.