Closed s-ayush2903 closed 4 years ago
Why did you create a pr for an issue that has already been claimed by someone else, who has already made a pr?
Why did you create a pr for an issue that has already been claimed by someone else, who has already made a pr?
My apologies, Sorry!
As the above pull request makes the changes that were asked to make in the #2360 and to satisfy which, another #2444 was opened and neither of which includes the requested changes like ReCaptcha_Key storage issue and the build issue(e.g. the build fails in both of the previous MRs when key is not supplied) and the issue related to usage of timber, so REOPENING it.
@liveHarshit please review
✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of db2b51f1df98b41eaf43eb03b61b88929e954f93. Here's the output:
spotless check
> Task :spotlessCheck UP-TO-DATE
I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!
db2b51f
@s-ayush2903 status ?
@s-ayush2903 are you still working on this?
Fixes #2350
Changes: Some dependencies required for ReCaptcha implementation were added, and corresponding changes were made accordingly.
I am with this embedding two screenRecordings that display the proposed changes.
(This represents the state of the app when the key is present)
(And This represents the state of the app when the key is not present)