search

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi
Apache License 2.0
2.42k stars 1.11k forks source link

feat: Implemented ReCaptcha Verification in sign_up process #2446

Closed s-ayush2903 closed 4 years ago

s-ayush2903 commented 4 years ago

Fixes #2350

Changes: Some dependencies required for ReCaptcha implementation were added, and corresponding changes were made accordingly.

I am with this embedding two screenRecordings that display the proposed changes.

(This represents the state of the app when the key is present) GIF-200109_151419

(And This represents the state of the app when the key is not present) GIF-200109_152147

atm1504 commented 4 years ago

Why did you create a pr for an issue that has already been claimed by someone else, who has already made a pr?

s-ayush2903 commented 4 years ago

Why did you create a pr for an issue that has already been claimed by someone else, who has already made a pr?

My apologies, Sorry!

s-ayush2903 commented 4 years ago

As the above pull request makes the changes that were asked to make in the #2360 and to satisfy which, another #2444 was opened and neither of which includes the requested changes like ReCaptcha_Key storage issue and the build issue(e.g. the build fails in both of the previous MRs when key is not supplied) and the issue related to usage of timber, so REOPENING it.

s-ayush2903 commented 4 years ago

@liveHarshit please review

ci-reporter[bot] commented 4 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of db2b51f1df98b41eaf43eb03b61b88929e954f93. Here's the output:

spotless check
> Task :spotlessCheck UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for db2b51f ##### `spotless check` ``` > Task :spotlessCheck UP-TO-DATE ```
This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.
batbrain7 commented 4 years ago

@s-ayush2903 status ?

angmas1 commented 4 years ago

@s-ayush2903 are you still working on this?