search

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi
Apache License 2.0
2.42k stars 1.11k forks source link

Search bar for skills does not close on going back with android nav button #2459

Closed shashwatjolly closed 4 years ago

shashwatjolly commented 4 years ago

The search bar for skills closes when we press the action bar back button or the "x" on the search bar. But it does not close when we press the android navigation back button.

Expected Behaviour

The search bar should behave the same as it does when the action bar back button is pressed.

Steps to reproduce it

  1. Press the search button in the Skills page.
  2. Repeatedly pressing the android back button does not cause anything. Ideally the search bar should close.

Would you like to work on the issue?

Yes

rob729 commented 4 years ago

@shashwatjolly are you still working on this issue?

shashwatjolly commented 4 years ago

@rob729 Yes PR is already up