search

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi
Apache License 2.0
2.42k stars 1.11k forks source link

fix: Shimmer layout appears when switching back to SkillListingFragment #2466

Closed rob729 closed 4 years ago

rob729 commented 4 years ago

Fixes #2438

Changes: Added a check in onResume that when skills list is not empty hide shimmer.

Screenshots for the change:

ci-reporter[bot] commented 4 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 9831ddd3ed4ce429a362c02bc31514ad803126c3. Here's the output:

spotless check
> Task :spotlessCheck UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for 9831ddd ##### `spotless check` ``` > Task :spotlessCheck UP-TO-DATE ```
This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.
rob729 commented 4 years ago

@atm1504 Please review this PR.

rob729 commented 4 years ago

@iamareebjamal Please review this PR.