search

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi
Apache License 2.0
2.42k stars 1.11k forks source link

fix: Added unit test for datahelper class #2476

Closed pallav12 closed 4 years ago

pallav12 commented 4 years ago

Fixes #2100

Changes: Made feedback activity testable and added unit test, since only testable unit in Feedback activity is format date. So migrated getDate() function to DateTimeHelper and added unit test for all other functions of DateTimeHelper

Screenshots for the change: Screenshot (8)

ci-reporter[bot] commented 4 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 69702671aaf85f07031a0e9fedabd28de6fa6c38. Here's the output:

lint check
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

Failed build for b8a272d ##### `Run Tests` ``` > Task :assemble UP-TO-DATE ```
Failed build for b8a272d ##### `Run Tests` ``` > Task :assemble UP-TO-DATE ```
Failed build for 383fb7e ##### `Run Tests` ``` > Task :app:preBuild UP-TO-DATE ```
Failed build for 45aa0c5 ##### `Run Tests` ``` > Task :app:preBuild UP-TO-DATE ```
Failed build for 45aa0c5 ##### `Run Tests` ``` > Task :app:preBuild UP-TO-DATE ```
Failed build for 02bbb76 ##### `spotless check` ``` > Task :spotlessCheck UP-TO-DATE ```
Failed build for 02bbb76 ##### `spotless check` ``` > Task :spotlessCheck UP-TO-DATE ```
Failed build for 9557e65 ##### `Run Tests` ``` > Task :app:preBuild UP-TO-DATE ```
This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.
ci-reporter[bot] commented 4 years ago

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 9557e65fd0aa687d8bd4705ab8ef98afd93a97e1. Here's the output:

Run Tests
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.
pallav12 commented 4 years ago

Thanks @iamareebjamal for having patience... I'll try to avoid any redundancies from now.