Setting the app on appetize.io for easy testing.

fossasia / susi_android

SUSI.AI Android App https://play.google.com/apps/testing/ai.susi

Apache License 2.0

2.42k stars 1.11k forks source link

Setting the app on appetize.io for easy testing. #702

Closed mayank408 closed 7 years ago

mayank408 commented 7 years ago

Actual Behaviour

Apk is not added to the pull request.

Expected Behaviour

Apk must be added after the pull request for easy testing.

mayank408 commented 7 years ago

@betterclever Pls add your comments

betterclever commented 7 years ago

Okay. This can be done in the following way.

After APK build is complete and upload-apk.sh is executing, verify if it is a pull request or regular commit (like merge commit). An 'if' check is there already.
For PR, upload APK to transfer.sh service using, their curl command. See more here https://transfer.sh/
Use circle-github-bot (https://github.com/themadcreator/circle-github-bot), to post comment of trasfer.sh link to apk back to Pull Request.

chiragw15 commented 7 years ago

No one is actually going to download apk from the PR and then transfer it to mobile and install. Therefore it is useless to do it for every PR. It will be better if we somehow can display preview on appetize.io or similar service.

betterclever commented 7 years ago

@chiragw15 Appetize.io has only 100 minutes viewership in free tier + slightly sluggish experience. Also, to experience some features like Hotword Detection, you need to check on an actual device. Thus, it might be helpful for non Android Developers to test PRs quickly without needing to pull from PR and set it up on on their devices. Installing an APK is quick and relatively easy task I guess. We should add both options according to me.

chiragw15 commented 7 years ago

IMO there is no need of automatically adding apk file to every PR. It is just wastage to add apk for a 1-2 line PR. For larger PR, developer should add apk in PR manually. @mayank408 if you find any way to automate preview on appetize.io or any other similar platform, proceed with it else close this.