fossasia / susi_chromebot

SUSI.AI Chrome Extension
GNU Lesser General Public License v2.1
1.54k stars 140 forks source link

fixed:#246 #258

Closed saikat041 closed 6 years ago

saikat041 commented 6 years ago

Fixes #246

Checklist

Short description of what this resolves:

Now the error in logging in is shown using bootstrap alert method.

Changes proposed in this pull request:

screenshot 19

-

-

ms10398 commented 6 years ago

Please squash commits

saikat041 commented 6 years ago

@ms10398 please review it

saikat041 commented 6 years ago

@ms10398 now its done

saikat041 commented 6 years ago

@ms10398 please review it

ms10398 commented 6 years ago

@gabru-md @stealthanthrax @sachincool Please review

ms10398 commented 6 years ago

Yeah you should add it too and please reference issue no. in your pull request.

saikat041 commented 6 years ago

@gabru-md But after successful log in the page is changed. And showing "You are logged in " in that page is unnecessary i think.

sansyrox commented 6 years ago

@saikat041 , you can add "you are logged in as: email" for the page

gabru-md commented 6 years ago

@saikat041 i get your point. So I guess we better change the alert text from alert(response.message) to something more relevant. Can you please do it? something like : alert("Logged in!") ?

gabru-md commented 6 years ago

I guess I did not see that! It already says Logged in as : email. @ms10398 can you confirm if I am right ?

ms10398 commented 6 years ago

Yes its there @gabru-md

saikat041 commented 6 years ago

screenshot 21

Can we use this instead of alert("You are logged in as email")

gabru-md commented 6 years ago

Sure @saikat041 Please commit it and squash your commits so that it can be merged!

saikat041 commented 6 years ago

screenshot 23 Now all error are shown using bootstrap alert method.