Closed saikat041 closed 6 years ago
Please squash commits
@ms10398 please review it
@ms10398 now its done
@ms10398 please review it
@gabru-md @stealthanthrax @sachincool Please review
Yeah you should add it too and please reference issue no.
in your pull request.
@gabru-md But after successful log in the page is changed. And showing "You are logged in " in that page is unnecessary i think.
@saikat041 , you can add "you are logged in as: email" for the page
@saikat041 i get your point.
So I guess we better change the alert text from alert(response.message)
to something more relevant.
Can you please do it?
something like : alert("Logged in!")
?
I guess I did not see that! It already says Logged in as : email
.
@ms10398 can you confirm if I am right ?
Yes its there @gabru-md
Can we use this instead of alert("You are logged in as email")
Sure @saikat041 Please commit it and squash your commits so that it can be merged!
Now all error are shown using bootstrap alert method.
Fixes #246
Checklist
master
branch.Short description of what this resolves:
Now the error in logging in is shown using bootstrap alert method.
Changes proposed in this pull request:
-
-