Click to show password doesn't work as expected.

fossasia / susi_chromebot

SUSI.AI Chrome Extension

GNU Lesser General Public License v2.1

1.54k stars 140 forks source link

Closed championballer closed 6 years ago

championballer commented 6 years ago

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support requests here, instead ask your query in out Gitter channel at https://gitter.im/fossasia/susi_server

Current behavior: show password

The show password doesn't work on clicking on the checkbox.

Expected behavior: The password being entered by user should be legible and not be hidden

Steps to reproduce: Open login.html in src folder of susi_chromebot

Would you like to work on the issue? Yes

rupav commented 6 years ago

Already a PR for the same. Refer #319

championballer commented 6 years ago

Yeah, my bad. Goodluck working on that.

Also, could you comment here when it is merged? That will mean that there is no issue anymore?

championballer commented 6 years ago

@rupav Is the button you added working post the merge, for show password?

rupav commented 6 years ago

yes, I havent added the button, its a span tag (with an eye icon), clicking on which will let you see the password you typed.

championballer commented 6 years ago

It isn't working on my machine for some reason. Please check?

ezgif com-video-to-gif

haquezameer commented 6 years ago

@championballer Try to open this page from the extension instead opening the file directly. :smile:

championballer commented 6 years ago

Oh yeah, my bad. :smile: