Removed logout button and change password link

fossasia / susi_chromebot

SUSI.AI Chrome Extension

GNU Lesser General Public License v2.1

1.54k stars 140 forks source link

Removed logout button and change password link #338

Closed championballer closed 6 years ago

championballer commented 6 years ago

Fixes #333 #334 #339

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[x] The unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Removes logout button and change password link on login portal

Changes proposed in this pull request:

-Deleted the code related to the button -Deleted the code related to the link

bug

final

haquezameer commented 6 years ago

@championballer Can you mention the steps to reproduce the bug?

loginlogout

championballer commented 6 years ago

I just opened the login.html file in src folder and it was this way.

haquezameer commented 6 years ago

I just opened the login.html file in src folder and it was this way.

This is the default markup that exists in the page. Depending on if certain conditions are fulfilled, some markup is displayed or hidden through Javascript in login.js file.

I hope it clears the issue? :smile: If you think this resolves your issue then please close this.

Thank You. :tada:

championballer commented 6 years ago

But what is the requirement of this markup in the first place? If any user sees this, then it should be an issue?

championballer commented 6 years ago

Oh. No issues. :smile:

haquezameer commented 6 years ago

But what is the requirement of this markup in the first place? If any user sees this, then it should be an issue?

The problem here is that you are trying to access the login page directly instead of through the extension may be. Just try once through the extension if you are not doing that already?

haquezameer commented 6 years ago

Oh. No issues.

Sorry for the previous comment again. That was again a misunderstanding on my part. This code is indeed required for the functionality of the extension.

championballer commented 6 years ago

Sure, let me look into it.

haquezameer commented 6 years ago

Sure, let me look into it.

Have you created an issue for this one? If not please create one and if it's created then please mention the number on the Fixes line in your PR description.

Thanks.