Respond with text if Response Empty #373, Table Cut #358 - Githubissues

fossasia / susi_chromebot

SUSI.AI Chrome Extension

GNU Lesser General Public License v2.1

1.54k stars 140 forks source link

Respond with text if Response Empty #373, Table Cut #358 #374

Closed fragm3 closed 6 years ago

fragm3 commented 6 years ago

Fixes #373, #358, #378

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[x] The unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

On typing something gibberish or like random letters, no response is fetched(only loading). Now a response is shown.

When reply is of tweet type, the response is not cutoff from right side now.

The eye is inside the password field.

Screenshot:

For non response

screen shot 2018-09-27 at 2 38 56 pm

For table:

screen shot 2018-09-27 at 5 02 16 pm

For eye:

screen shot 2018-09-28 at 1 32 49 am

Changes proposed in this pull request:

On typing something gibberish or like random letters, Respond with Hmm... I'm not sure if i understand you correctly.
Fixed table tweet response text, it wont cut like it used to earlier.
Fix the eye inside input field

fragm3 commented 6 years ago

@rupav done!