[x] My branch is up-to-date with the Upstream master branch.
[x] The unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All the functions created/modified in this PR contain relevant docstrings.
Short description of what this resolves:
The error is due to accessing the data.answers[0] which can be undefined also
On logging in, the following console errors are present:
If message is of type map, the following console errors are given:
This error comes when you use chrome.storage.sync.set.. to set the data which is more than 8,192 bytes for a single item as chrome.storage.sync.set allows 8,192 QUOTA_BYTES_PER_ITEM.
Using chrome.storage.local.set.. to set the data instead of chrome.storage.sync.set.
As chrome.storage.local.set can contains 5242880 :QUOTA_BYTES.
On logout, following errors are given:
Content Security Policy does not allow inline javascript. So you have to put your javascript in a .js file and include it in your HTML.
Susi Response persistent:
Reason for not being persistent: The chrome allows only contains 5242880 byte in chrome.storage.sync.set. Using chrome.storage.local.set. to set the data and get data, solves the
in-persistency problem.
Fixes #366, #382, #402
Closed PR https://github.com/fossasia/susi_chromebot/pull/367 due to merge conflicts. The branch was older as the PR was reviewed late.
Checklist
master
branch.Short description of what this resolves:
The error is due to accessing the data.answers[0] which can be undefined also
On logging in, the following console errors are present:
This error comes when you use chrome.storage.sync.set.. to set the data which is more than 8,192 bytes for a single item as chrome.storage.sync.set allows 8,192 QUOTA_BYTES_PER_ITEM.
Using chrome.storage.local.set.. to set the data instead of chrome.storage.sync.set. As chrome.storage.local.set can contains 5242880 :QUOTA_BYTES.
Content Security Policy does not allow inline javascript. So you have to put your javascript in a .js file and include it in your HTML.
Susi Response persistent:
Reason for not being persistent: The chrome allows only contains 5242880 byte in chrome.storage.sync.set. Using chrome.storage.local.set. to set the data and get data, solves the in-persistency problem.
Old GIF of bug:
New:
Changes proposed in this pull request:
where is delhi