Fix - 417 - Adding Settings Link Inside Drop Down Menu

fossasia / susi_chromebot

SUSI.AI Chrome Extension

GNU Lesser General Public License v2.1

1.54k stars 139 forks source link

Fix - 417 - Adding Settings Link Inside Drop Down Menu #418

Closed championpaddler closed 5 years ago

championpaddler commented 5 years ago

Fixes #417 #### Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[x] All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Added Settings in drop down

screenshot from 2018-10-05 16-09-16

Changes proposed in this pull request:

-Added Settings Html inside drop down

championpaddler commented 5 years ago

@Akshat-Jain please review.

championpaddler commented 5 years ago

@hongquan @mariobehling @gabru-md Please review it.

fragm3 commented 5 years ago

@sk9331657 PR: https://github.com/fossasia/susi_chromebot/pull/388 solves this.

championpaddler commented 5 years ago

@sk9331657 PR: #388 solves this.

PR #388 Needs improvement, till then this can be merged.

fragm3 commented 5 years ago

@sk9331657 I don't think it works this way. The reviewers are yet to review it, making issue of already solved things is not justified.

championpaddler commented 5 years ago

@sk9331657 Actually, I didn't see your pull completely, I thought this issue is not solved. Next time please clearly mention the updates in Pr title.

ms10398 commented 5 years ago

@fragm3 you have closed your PR so should I review this PR? or you will reopen the PR

championpaddler commented 5 years ago

@ms10398 This can be fixed as #388 #420 Both have errors.

fragm3 commented 5 years ago

@ms10398 I had created a new PR yesterday as the closed one had conflicts. Link to new PR: https://github.com/fossasia/susi_chromebot/pull/420. I think this should be closed

championpaddler commented 5 years ago

@ms10398 This can be merged bcoz it just a small issue and as @fragm3. PR's are facing merge conflicts.

rupav commented 5 years ago

Duplicate of #388 and #420. So can be closed.

championpaddler commented 5 years ago

@rupav Ok .

championpaddler commented 5 years ago

@Akshat-Jain Please merge this also.

championpaddler commented 5 years ago

@AshishkrGoyal @akshatnitd Please merge it.

championpaddler commented 5 years ago

@gabru-md @Akshat-Jain @ms10398 Please merge this.

championpaddler commented 5 years ago

@championballer @ms10398 Please merge this one.

championpaddler commented 5 years ago

@akshatnitd Please review.

championpaddler commented 5 years ago

@mariobehling Please review this .

championpaddler commented 5 years ago

@akshatnitd #415

championpaddler commented 5 years ago

@akshatnitd Now it ready to be merged.

championpaddler commented 5 years ago

@akshatnitd Done.