Closed fragm3 closed 5 years ago
@zamhaq @Orbiter @gabru-md @ms10398 @rupav please review.
@gabru-md The color picker used is external dependency, the CSS files wont make it slower, since its just styling. And will be loaded in the settings page only, so maybe it's fine? Also, I can minify the css, should I do that? Thanks for your review.
@rupav You gave the wrong link.
The web app order:
How about we order like this:
Oh sorry @fragm3 . Correct link: https://github.com/fossasia/susi_chromebot/pull/425#issuecomment-427737133.
Yes agreed, about
as second last option makes sense.
Merge conflicts due to renaming of file. After renaming:
Fixes #381
PR: https://github.com/fossasia/susi_chromebot/pull/388 had undetectable merge conflicts, so creating a new PR.
Checklist
master
branch.Short description of what this resolves:
Screenshots:
Before:
Changes proposed in this pull request: