fossasia / susi_chromebot

SUSI.AI Chrome Extension
GNU Lesser General Public License v2.1
1.54k stars 139 forks source link

Redesign Settings Pages, More functionality#381 #420

Closed fragm3 closed 5 years ago

fragm3 commented 5 years ago

Fixes #381

PR: https://github.com/fossasia/susi_chromebot/pull/388 had undetectable merge conflicts, so creating a new PR.

Checklist

Short description of what this resolves:

Screenshots:

screenshot 2018-09-30 at 9 28 17 pm screenshot 2018-09-30 at 9 28 24 pm screenshot 2018-09-30 at 9 32 56 pm

Before:

screenshot 2018-09-30 at 9 15 37 pm

Changes proposed in this pull request:

fragm3 commented 5 years ago

@zamhaq @Orbiter @gabru-md @ms10398 @rupav please review.

fragm3 commented 5 years ago

@gabru-md The color picker used is external dependency, the CSS files wont make it slower, since its just styling. And will be loaded in the settings page only, so maybe it's fine? Also, I can minify the css, should I do that? Thanks for your review.

fragm3 commented 5 years ago

@rupav You gave the wrong link.

The web app order:

screenshot 2018-10-08 at 5 12 18 pm

How about we order like this:

rupav commented 5 years ago

Oh sorry @fragm3 . Correct link: https://github.com/fossasia/susi_chromebot/pull/425#issuecomment-427737133. Yes agreed, about as second last option makes sense.

fragm3 commented 5 years ago
screenshot 2018-10-16 at 3 12 09 pm

Merge conflicts due to renaming of file. After renaming:

screenshot 2018-10-16 at 3 16 59 pm