Add scroll to top in scroll window #342

fragm3 commented 5 years ago

Fixes #342

Closed PR https://github.com/fossasia/susi_chromebot/pull/371 due to some multiple merge conflicts.

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[x] The unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

Added scroll to top functionality scroll-up-down

Changes proposed in this pull request:

Scroll to top
Code indentation
Removed redundant new lines

fragm3 commented 5 years ago

Using ternary wont work here, error:

@ms10398 @gabru-md @rupav @zamhaq please review

gabru-md commented 5 years ago

@fragm3 can you try it in this way ?

scrollIconBottom.style.display = (messages.scrollTop === 0)? "block":"none" ;

the screenshot says that there is no assignment, so you can use the way I suggested above. Give it a try and if it works, then it is good, else we can simply merge this PR of yours and then iterate on this one.

gabru-md commented 5 years ago

helpss

something like this should get this working in no time. if there is still some problem then we can do it in the later PRs.

Thanks! Cheers!

fragm3 commented 5 years ago

Done , please review @gabru-md @ms10398 @zamhaq

fragm3 commented 5 years ago

@rupav Done the changes, squashed the commits.

fossasia / susi_chromebot