Added eye feature in change password form - Githubissues

fossasia / susi_chromebot

SUSI.AI Chrome Extension

GNU Lesser General Public License v2.1

1.54k stars 138 forks source link

Added eye feature in change password form #500

Open samagragupta opened 5 years ago

samagragupta commented 5 years ago

Fixes #466

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

eye eye

Changes proposed in this pull request:

Added eye in the password fields

samagragupta commented 5 years ago

@rupav Uploaded the gif

samagragupta commented 5 years ago

@gabru-md @hkedia321 Please review.

samagragupta commented 5 years ago

@fragm3 There is no need of a function as there would event Listener for every eye.

samagragupta commented 5 years ago

@ms10398 @hkedia321 Please review.