Function to check valid extension for Background image URL added - Githubissues

fossasia / susi_chromebot

SUSI.AI Chrome Extension

GNU Lesser General Public License v2.1

1.54k stars 138 forks source link

Function to check valid extension for Background image URL added #504

Closed neeraj3029 closed 5 years ago

neeraj3029 commented 5 years ago

Fixes #503

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[ ] I have added necessary documentation (if appropriate)
[ ] All the functions created/modified in this PR contain relevant docstrings.

Short description of what this resolves:

It checks the validity of background URL provided

screenshot 2018-12-13 at 2 50 08 pm

neeraj3029 commented 5 years ago

@hkedia321 Done, please review!

neeraj3029 commented 5 years ago

@hkedia321 I've corrected the pattern. Screenshots:

screenshot 2018-12-27 at 8 47 06 pm

neeraj3029 commented 5 years ago

@akshatnitd @ms10398 Please review

neeraj3029 commented 5 years ago

@fragm3 Done!