Solved: overlapping Issue of ScrollIcon and top margin Issue of login page - Githubissues

fossasia / susi_chromebot

SUSI.AI Chrome Extension

GNU Lesser General Public License v2.1

1.54k stars 140 forks source link

Solved: overlapping Issue of ScrollIcon and top margin Issue of login page #551

Open hardikhere opened 4 years ago

hardikhere commented 4 years ago

overlapping of scrollIconUp/Bottom with scollbar is fixed and login page's top margin fixed.

Issue #550 and #549 is resolved kindly check it out.

Fixes #

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[x] The unit tests pass locally with my changes
[x] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation
Issues

currently, the scroll icon is overlapping with the scroll bar. also some text may hide behind the scroll icon.

overlapping

Also, there is unnecessary top margin on the login page, which hides other options.

Changes proposed in this pull request:

harshit-soora commented 3 years ago

Hey @hardikhere
I'm new to this open source environment, I just had one concern. After you edit your changes, do we have to build the code or something In my case, Travis CI build fails