Closed jogendra closed 6 years ago
@AnupKumarPanwar @batbrain7 please review!
@imjog if I close and reopen the app how is it being checked that the chats have actually received a feedback in the past?
@chashmeetsingh It is not checking and will display thumbs up and down again because from server side we don't have any check if the feedback is submitted or not. All we can do is temporary disable thumbs up and down or we can save this info in realm database but whenever we load message from server again, thumbs up and down will come back. @AnupKumarPanwar @batbrain7 Am I right?
Yes, this is what is happening if we need to permanently reflect this, we have to make some changes to the Memory API from the server
@batbrain7 I am not sure how memory API can do that because messages don't have any ID associated and also, a anonymous user can submit feedback too.
IMO the Issue is still not fixed if user is able to provide feedback after he opens the app again.
Yes, thats a tricky part. We are allowing anonymous feedbacks as well as we need to identify the feedbacks uniquely.
@chashmeetsingh Web and Android client are also having this temporary feature. For now, can we add this? and in the future when server-side implement this, we will implement here too.
Ok, let'd iterate on this. Cheers.
Fixes #380, #385
Changes:
Screenshots for the change: