search

fossasia / susi_iOS

SUSI AI iOS app http://susi.ai
Apache License 2.0
1.87k stars 139 forks source link

Missing Alert Action on LoginVc and ChatVc #472

Open baquer opened 5 years ago

baquer commented 5 years ago

Actual Behaviour

No Alert Action on loginVc and ChatVc If Internet goes down or disconnected then user need to close the app.

Expected Behaviour

Alert Action should be available in order to avoid this problem.

Screenshots of the issue

screenshot 2018-12-05 at 11 24 13 pm

Would you like to work on the issue?

Yes

chashmeetsingh commented 5 years ago

Why do we need this? I suppose after internet connection is available, this alert goes away.

baquer commented 5 years ago

@chashmeetsingh , the alert is not dismissing , when connected to internet again, and leads to a deadlock kind of situation. I tested it in Xcode Simulator , and not sure about , how it behaves in physical device 😀

baquer commented 5 years ago

@jogendra , for better user experience , we can use notification banner .

Here are the GIF .

ezgif26971ecb3061c

ezgif295433e8aeeac

What's your opinion about this ?

jogendra commented 5 years ago

@baquer Yeah it is better idea, I was thinking about this one!

baquer commented 5 years ago

So, should i go for it ? , or if you have some other better option than this one, until then we can hold this issue.

jogendra commented 5 years ago

@baquer Yes please go with it.