Closed baquer closed 5 years ago
@chashmeetsingh , @jogendra , @SIMRAN1 , Please review the PR.
@jogendra , i am thinking of removing the green notification banner , because it shows the success notification every time when the "internet is available" gets printed into the console , what's your opinion in this ?
@baquer We definitely DON'T want showing notification all time, it is very bad practice. All we want is:
@baquer Try using better PR title instead of just putting the issue number. The pull request made without following guidelines will not be reviewed by the mentors.
@jogendra , Please review the PR , changes made as suggested by you.
@jogendra , i checked this and in my case it is working perfectly ,these are the SS which i am getting
Can you please share me the output which you are getting , so that i get to know about the problem , which you are facing.
@baquer Please resolve the conflicts
@baquer Please resolve the conflicts
@jogendra , Done.
Closing the PR since it is having many bugs after 2-3 reviews. Please feel free to open a new PR with a new implementation.
Fixes #472 Alert Action issue using Banner Notification
Screenshots for the change: