Aboutus Section Implemented

fossasia / susi_iOS

SUSI AI iOS app http://susi.ai

Apache License 2.0

1.87k stars 139 forks source link

Aboutus Section Implemented #478

Closed baquer closed 5 years ago

baquer commented 5 years ago

Fixes #477

Screenshots for the change: screenshot 2018-12-27 at 1 58 27 am screenshot 2018-12-27 at 1 52 46 am

baquer commented 5 years ago

@chashmeetsingh , @jogendra , @SIMRAN1 please review the PR

baquer commented 5 years ago

Here is the demo URL of the implementation https://youtu.be/jicl0qjsb00

baquer commented 5 years ago

@jogendra Please Review the PR again.

screenshot 2018-12-28 at 1 42 30 am

baquer commented 5 years ago

@jogendra

suggest format attributes like textColour and Size! or grey colour and size 17 is fine ? and I formatted the text by giving proper spacing between the characters.
Is this size of logo and top margin is fine ?
I looked into the failing circle-ci linting and found that, it is failing due to large number of characters in line as line should be 150 characters or less

jogendra commented 5 years ago

suggest format attributes like textColour and Size! or grey colour and size 17 is fine ? and I formatted the text by giving proper spacing between the characters.

Colors, size and all is fine, I am pointing about the the way text written eg. there is no space after ., space before , did you get me?

Is this size of logo and top margin is fine ?

Make is little more small

I looked into the failing circle-ci linting and found that, it is failing due to large number of characters in line as line should be 150 characters or less

You have to solve that by using swift mutiline feature. Put the string between ''' ''' ex.

let loremIpsum = """
Lorem ipsum is the exapmle text
"""

baquer commented 5 years ago

@jogendra , making multiline leads to unequal spacing between words , unaligned characters and looking weird . This is the storyboard with out multiline screenshot 2018-12-29 at 12 48 23 pm

baquer commented 5 years ago

@jogendra , done the changes suggested by you ,

screenshot 2018-12-30 at 2 01 42 am

circle-ci is failing due to issues in other files , will make a new PR for failing circle-ci linting.

please review the changes ☺️

jogendra commented 5 years ago

Changes made in https://github.com/fossasia/susi_iOS/pull/478#issuecomment-450471945 looks good. Do not make it multiline, disable the character limit in swiftlint config file. Look like the logo is squeezed, please make sure logo is in the proper ratio.

baquer commented 5 years ago

@jogendra , Here is the SS

screenshot 2018-12-31 at 2 26 14 am

can i squash the commits ?