search

fossasia / susi_iOS

SUSI AI iOS app http://susi.ai
Apache License 2.0
1.87k stars 139 forks source link

Feat: Share Skill Feature on Skill Detail View Controller #488

Closed baquer closed 5 years ago

baquer commented 5 years ago

Fixes #487

Share Skill feature ob skill detail view controller

Screenshots for the change:

screenshot 2019-01-18 at 12 56 44 am screenshot 2019-01-18 at 12 56 08 am screenshot 2019-01-18 at 12 51 26 am

baquer commented 5 years ago

@jogendra , @chashmeetsingh , @SIMRAN1 Please review the PR.

chashmeetsingh commented 5 years ago

Wouldn't it be better to have an UIBarButtonItem in the nav bar instead?

jogendra commented 5 years ago

Wouldn't it be better to have an UIBarButtonItem in the nav bar instead?

Yes, I agree with @chashmeetsingh. That would be a better idea. You can put a dotted menu on the right and show Report Skill and Share Skill option when the user click the menu (like google using in their iOS apps)

baquer commented 5 years ago

@jogendra , @chashmeetsingh , yeah its a great idea , its also optimised the code and reduces the LOC, will make a commit soon😀

baquer commented 5 years ago

@chashmeetsingh , @jogendra here is the SS ,Please review the PR.

screenshot 2019-01-20 at 7 21 50 pm

baquer commented 5 years ago

@jogendra , updated SS

screenshot 2019-02-03 at 4 59 59 pm