fossasia / susi_iOS

SUSI AI iOS app http://susi.ai
Apache License 2.0
1.87k stars 139 forks source link

Toast notification when feedback text field is empty and user click the post button #504

Closed baquer closed 5 years ago

baquer commented 5 years ago

Actual Behaviour

No notification when user click the post button with empty text field

Expected Behaviour

It should alert the user about the feedback text field

Would you like to work on the issue?

Yes

baquer commented 5 years ago

@jogendra , actually in this issue , when the user is logged-in and try to post feedback with empty feedback text field , it is not showing any alert , while when the user is not logged-in and try to post the feedback it pops up the alert controller for login.
Here is the video url of this issue Video URL .Please see this issue.

jogendra commented 5 years ago

@baquer Yes, this is left intentionally. When the user is logged-in and clicks post button, there is not any alert because the user knows that it does not make any sense to get it clicked without any text so there is no need of any alert. But when the user is not logged-in we show the alert to login user so that user come to know that only logged-in user can post feedback.

baquer commented 5 years ago

thanks @jogendra , for explaining this to me ☺️ now i am closing this issue.