search

fossasia / susi_iOS

SUSI AI iOS app http://susi.ai
Apache License 2.0
1.87k stars 141 forks source link

Feat: Add resend verification link for the user #537

Closed baquer closed 5 years ago

baquer commented 5 years ago

Fixes #536

Changes:

  1. Add resend link button
  2. Call API for resending the verification link to the user.

Screenshots for the change:

Screenshot 2019-03-24 at 2 41 06 AM

baquer commented 5 years ago

@chashmeetsingh, @jogendra, Please review the PR.

baquer commented 5 years ago

keep the button small in size and place just below and right side of Sign up button.

@jogendra, There is an Activity Indicator just below the signup button, so can I put Activity Indicator after the resend button? and can you please explain to me about the right side of the signup button?

baquer commented 5 years ago

keep the button small in size and place just below and right side of Sign up button.

Done @jogendra

Screenshot 2019-04-03 at 11 36 09 PM

jogendra commented 5 years ago

@baquer Keep the button right side and make it little smaller.

baquer commented 5 years ago

@jogendra

Is this Okay?

Screenshot 2019-04-04 at 10 54 29 PM

jogendra commented 5 years ago

Looks okay to me. I am little bit confused, should we place here to just below email text field. @chashmeetsingh ?

chashmeetsingh commented 5 years ago

This place looks fine but shouldn't it be center aligned?

baquer commented 5 years ago

Looks okay to me. I am little bit confused, should we place here to just below email text field. @chashmeetsingh ?

@jogendra, Any update?

jogendra commented 5 years ago

There is a problem with the API method. Simulator Screen Shot - iPhone 8 - 2019-05-24 at 00 33 45

baquer commented 5 years ago

There is a problem with the API method. Simulator Screen Shot - iPhone 8 - 2019-05-24 at 00 33 45

@jogendra have you tried it using a new unverified email or the existing email account? because in case of existing email or account it will give server error.

baquer commented 5 years ago

@jogendra, at my end it is working fine.

Screenshot 2019-05-24 at 1 17 00 AM

Screenshot_20190524-011717

jogendra commented 5 years ago

@baquer Handle the error properly. when the user is already registered and request resend, show them the same, not that problem connecting to the server.

baquer commented 5 years ago

@baquer Handle the error properly. when the user is already registered and request resend, show them the same, not that problem connecting to the server.

Done @jogendra

Screenshot 2019-06-15 at 12 11 58 AM

baquer commented 5 years ago

Follow https://stackoverflow.com/questions/17703510/dyld-library-not-loaded-reason-image-not-found to fix the lint issue. Other than that, looks good to me.

Will fix the lint issue.

jogendra commented 5 years ago

@baquer change 11.2 to 12.2 in https://github.com/fossasia/susi_iOS/blob/master/Scripts/build_for_testing.sh

baquer commented 5 years ago

@baquer change 11.2 to 12.2 in https://github.com/fossasia/susi_iOS/blob/master/Scripts/build_for_testing.sh

doing it.

baquer commented 5 years ago

Thanks, @jogendra It's working now 😁

jogendra commented 5 years ago

@baquer Yeah finally

@chashmeetsingh please review :)

baquer commented 5 years ago

@baquer Yeah finally

@chashmeetsingh please review :)

@jogendra Yeah, also I am thinking of fixing this issue in other iOS projects.