search

fossasia / susi_iOS

SUSI AI iOS app http://susi.ai
Apache License 2.0
1.87k stars 141 forks source link

Feat:Showcase in Chat VC #554

Closed baquer closed 5 years ago

baquer commented 5 years ago

Fixes #553

Changes: Add showcase in Chat VC.

Screenshots for the change:

Screenshot 2019-04-21 at 3 04 23 AM

baquer commented 5 years ago

@chashmeetsingh, @jogendra, Please review the PR.

chashmeetsingh commented 5 years ago

Wouldn't it be a good idea to remove the black overlay over the buttons?

baquer commented 5 years ago

Wouldn't it be a good idea to remove the black overlay over the buttons?

@chashmeetsingh, actually the black overlay over the Susi button is due to the Impact or overloading of a showcase on skill button, Here is the difference.

Screenshot 2019-05-11 at 11 56 46 PM

Screenshot 2019-05-11 at 11 56 51 PM

baquer commented 5 years ago

Can you please resolve the conflicts so that I can review the PR?

Done @jogendra