search

fossasia / susi_iOS

SUSI AI iOS app http://susi.ai
Apache License 2.0
1.87k stars 139 forks source link

Feat: Swift 5 Migration #560

Closed baquer closed 5 years ago

baquer commented 5 years ago

Fixes #539

Changes: Conversion to swift 5

Screenshots for the change:

N/A

baquer commented 5 years ago

@chashmeetsingh, @jogendra, Please Review the PR.

baquer commented 5 years ago

@jogendra, after migrating to swift 5.0, the project is not building due to JI pod failure, as JI pod is not updated for swift 5.0. I will look into it.

baquer commented 5 years ago

@jogendra, the project is building now by manually making changes in JI and Readabilitykit pod files. Any idea of how to make a permanent change in these pods?

jogendra commented 5 years ago

@baquer If the pod is not in use, remove the Pod or find the good alternative. Otherwise, make a pull request to made changes in pod. The other thing we could do is make a fork to our org and make changes and use it but this is not the good way and I am not sure we will fork other repo in our org. @mariobehling could we do that?

baquer commented 5 years ago

@baquer If the pod is not in use, remove the Pod or find the good alternative. Otherwise, make a pull request to made changes in pod. The other thing we could do is make a fork to our org and make changes and use it but this is not the good way and I am not sure we will fork other repo in our org. @mariobehling could we do that?

@jogendra, I think by Changing the outdated pod to the latest pod is a better and long term solution.

baquer commented 5 years ago

I will make a PR soon for the new pods.

baquer commented 5 years ago

@jogendra the pods which I mentioned earlier are now updated to the latest version, now the project is building successfully without any errors. Please check it in your local repository too. So should I change the pods or leave it here itself?

jogendra commented 5 years ago

@baquer The circle-ci test is failing. PR cannot be reviewed/merge till it pass all the test. Please first pass all the test, test it well from your side then ping here.

baquer commented 5 years ago

@baquer The circle-ci test is failing. PR cannot be reviewed/merge till it pass all the test. Please first pass all the test, test it well from your side then ping here.

Okay, @jogendra I will try to fix the failing issue of circle ci.

jogendra commented 5 years ago

Closing the PR due to inactivity. Feel free to open a new PR.