fossasia / susi_iOS

SUSI AI iOS app http://susi.ai
Apache License 2.0
1.87k stars 141 forks source link

Feat:- Account Section Implementation. #561

Open baquer opened 5 years ago

baquer commented 5 years ago

Fixes #559, #544, #557

Screenshots for the change:

Screenshot 2019-06-03 at 3 03 58 AM

baquer commented 5 years ago

@chashmeetsingh, @jogendra, Please Review the PR

baquer commented 5 years ago

Updated SS

Screenshot 2019-06-05 at 6 35 59 PM

@jogendra, please review and merge this PR. Will solve Other issues related to this PR in other PRs.

baquer commented 5 years ago

For the UI:

  • There should be option to change avatar from clicking the image.
  • AspectFit image in avatar imageView
  • Align delete button left and keep it just below last textField.
  • Add shadow of radius 10 to the avatar imageview and keep border white color

@jogendra, I will do the changes, just to be clear I am thinking of implementing the upload Avatar or image in a different storyboard where user can pick either gravatar, avatar or Image from the gallery by clicking the image view just like we have in our Susi web app. And that's the reason why I made a click button in the account settings storyboard that redirects to the upload image storyboard because making all the things in a single storyboard is somewhat messy. @jogendra and @chashmeetsingh what's your view on this?

jogendra commented 5 years ago

I think if you are not adding any additional functionality other than just uploading image then, it will be good to do in same controller

baquer commented 5 years ago

I think if you are not adding any additional functionality other than just uploading image then, it will be good to do in same controller

Yes, I am thinking of implementing the user dashboard in the same storyboard.

baquer commented 5 years ago

For the UI:

  • There should be option to change avatar from clicking the image.
  • AspectFit image in avatar imageView
  • Align delete button left and keep it just below last textField.
  • Add shadow of radius 10 to the avatar imageview and keep border white color

Changes are done @jogendra, I changed the shadow of radius to 2 because if we change it to 10 then it is overlapping with the user Image Screenshot 2019-06-07 at 3 10 27 AM

Here is the updated SS

Screenshot 2019-06-07 at 3 16 37 AM

jogendra commented 5 years ago

I changed the shadow of radius to 2 because if we change it to 10 then it is overlapping with the user Image

Add outer shadow, not inner!

baquer commented 5 years ago

I changed the shadow of radius to 2 because if we change it to 10 then it is overlapping with the user Image

Add outer shadow, not inner!

Done @jogendra

Here is the output

Screenshot 2019-06-07 at 5 55 26 PM

baquer commented 5 years ago

@jogendra, please review

baquer commented 5 years ago

Update M13Checkbox Pod, it is giving me the errors.

Done @jogendra

jogendra commented 5 years ago

@baquer Have you followed https://stackoverflow.com/questions/26024100/dyld-library-not-loaded-rpath-libswiftcore-dylib to fix the Lint error?

baquer commented 5 years ago

@baquer Have you followed https://stackoverflow.com/questions/26024100/dyld-library-not-loaded-rpath-libswiftcore-dylib to fix the Lint error?

@jogendra Yes I tried almost every answer, but none of them are working, I think the problem is either with the WWDRCA certificate or with the Circle CI integration. I will try to solve this within this week

baquer commented 5 years ago

@jogendra On Circle Ci Website I found out this warning "Your project references CircleCI 1.0 or it has no configuration. CircleCI 1.0 and projects without configuration files are no longer supported. You must update your project to use CircleCI 2.0 configuration to continue."

jogendra commented 5 years ago

@baquer We are using version 2. May be change some cofig params or xcode version to get it done.

baquer commented 5 years ago

@baquer We are using version 2. May be change some cofig params or xcode version to get it done.

@jogendra Okay I will try to fix this by changing parameters.