fossasia / susi_linux

Hardware for SUSI AI https://susi.ai
Apache License 2.0
1.6k stars 148 forks source link

Added async calls for the server check #469

Closed sansyrox closed 5 years ago

sansyrox commented 5 years ago

Fixes #464

Checklist

Test Passing

Short description of what this resolves:

Changes proposed in this pull request:

sansyrox commented 5 years ago

Sure @hongquan . I also want to test this PR first(I'll do it at the weekend) and make the changes suggested by you 🖖

sansyrox commented 5 years ago

Sorry for not updating it for a long time. @hongquan , I have updated it. Please have a look.

sansyrox commented 5 years ago

@hongquan , updated

hongquan commented 5 years ago

Thanks, @stealthanthrax

norbusan commented 5 years ago

Hi @stealthanthrax this change produced some regression - does it work on Raspi? With this patch I get communication errors between susi server and susi linux:

With patch evey 10s sec the following warning on the server side

Apr 16 13:51:11 burischnitzel start.sh[14160]: 2019-04-16 13:51:11.146 WARN org.eclipse.jetty.http.HttpParser  - Illegal character 0x16 in state=START for buffer HeapByteBuffer@626b966c[p=1,l=319,c=8192,r=318]={\x16<<<\x03\x01\x01:\x01\x00\x016\x03\x03\xB2{\x8f\xBd\x80\x1a\xA9...\x02X>.\xC4egm{\xC7\xC5\x82j\x9d1>>>tent-Type: applic...\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00}
Apr 16 13:51:11 burischnitzel start.sh[14160]: 2019-04-16 13:51:11.147 WARN org.eclipse.jetty.http.HttpParser  - bad HTTP parsed: 400 Illegal character 0x16 for HttpChannelOverHttp@2fe04398{r=0,c=false,a=IDLE,uri=null}

and on the susi linux side:

2019-04-16 13:52:05 DEBUG:urllib3.connectionpool: Starting new HTTPS connection (1): 127.0.0.1:4000
2019-04-16 13:52:15 DEBUG:urllib3.connectionpool: Starting new HTTPS connection (1): 127.0.0.1:4000
2019-04-16 13:52:25 DEBUG:urllib3.connectionpool: Starting new HTTPS connection (1): 127.0.0.1:4000
2019-04-16 13:52:35 DEBUG:urllib3.connectionpool: Starting new HTTPS connection (1): 127.0.0.1:4000
...

This is on my desktop, not a raspi, though. Do you have an explanation for that?

norbusan commented 5 years ago

It seems that something in the encoding of the request is going wrong.