trigger song_modulation() when speaking stop - Githubissues

fossasia / susi_linux

Hardware for SUSI AI https://susi.ai

Apache License 2.0

1.61k stars 148 forks source link

trigger song_modulation() when speaking stop #504

Closed alok760 closed 5 years ago

alok760 commented 5 years ago

Fixes #503

Checklist

[x] I have read the Contribution & Best practices Guide and my PR follows them.
[x] My branch is up-to-date with the Upstream master branch.
[ ] The unit tests pass locally with my changes
[ ] I have added tests that prove my fix is effective or that my feature works
[x] I have added necessary documentation (if appropriate)
[x] All the functions created/modified in this PR contain relevant docstrings.

Test Passing

[x] The SUSI Server must be building on the pi on bootup
[x] The hotword detection should have a decent accuracy
[ ] SUSI Linux shouldn't crash when switching from online to offline and vice versa (failing as of now)
[ ] SUSI Linux should be able to boot offline when no internet connection available (failing)

Short description of what this resolves:

when saying "stop" the code expects there should be a key named "stop" https://github.com/fossasia/susi_linux/blob/3d43be48d5388d1fdd73374f96de8d27d65cf469/main/states/busy_state.py#L160 but the actual reply from the server is {'answer': ' stopped.'}

Changes proposed in this pull request:

handling the actual response and triggering the required function

alok760 commented 5 years ago

This issue was fixed in the susi_server repository with the commit https://github.com/fossasia/susi_server/commit/a507e9414f76c3758f48f5b0634348e7e2f3f147

sansyrox commented 5 years ago

@alok760 , I believe that this PR is not required anymore.