fossasia / susi_server

SUSI.AI server backend - the Artificial Intelligence server for personal assistants https://susi.ai
GNU Lesser General Public License v2.1
2.51k stars 1.08k forks source link

Fix Loading of List User in Admin #1288

Closed harsh-jindal closed 5 years ago

harsh-jindal commented 5 years ago

Fixes #1287

Changes: Made changes in aaa/GetUsers.java

harsh-jindal commented 5 years ago

@Orbiter @akshatnitd @fragm3 Please review.

fragm3 commented 5 years ago

I tried to make it work, a few days back. But the problem is, it's working on localhost, without any changes. How can we test if it can work on a real server instance? @akshatnitd

harsh-jindal commented 5 years ago

@fragm3 It doesn't work for me on my localhost. Also it's strange how it works for you because if you pass only access token as parameter you shall get Bad request. No parameter present as per the current code. Also you get java.array.outofbound exception because of page =0.

fragm3 commented 5 years ago

@harsh-jindal I tried with correct query parameters, which are specified in the Servlet file.

harsh-jindal commented 5 years ago

@fragm3 Then it would be best if we have some way to check it in on real server instance as said by you.