search

fossasia / susi_server

SUSI.AI server backend - the Artificial Intelligence server for personal assistants https://susi.ai
GNU Lesser General Public License v2.1
2.51k stars 1.08k forks source link

Update README with JDK8 installation and configuration steps for mac. #1474

Closed blossom2017 closed 4 years ago

blossom2017 commented 4 years ago

Fixes #[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]

Changes: [Add here what changes were made in this issue and if possible provide links.] Updates the readme with JDK 8 installation and configuration steps for mac users. Screenshots for the change:

codecov[bot] commented 4 years ago

Codecov Report

Merging #1474 into development will decrease coverage by 2.66%. The diff coverage is 27.84%.

Impacted file tree graph

@@                Coverage Diff                @@
##             development    #1474      +/-   ##
=================================================
- Coverage          18.53%   15.86%   -2.67%     
- Complexity           619      767     +148     
=================================================
  Files                165      228      +63     
  Lines              11337    17762    +6425     
  Branches            1874     3127    +1253     
=================================================
+ Hits                2101     2818     +717     
- Misses              8925    14419    +5494     
- Partials             311      525     +214
Impacted Files Coverage Δ Complexity Δ
src/ai/susi/Caretaker.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/ai/susi/EmailHandler.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/ai/susi/SkillTransactions.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/ai/susi/geo/GeoJsonReader.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/ai/susi/geo/OSMTile.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/ai/susi/graphics/AnimationGIF.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/ai/susi/json/JsonLDNode.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/ai/susi/json/JsonPath.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
src/ai/susi/mind/SusiFace.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
src/ai/susi/mind/SusiProcedures.java 58.82% <ø> (-11.77%) 3.00 <0.00> (-1.00)
... and 299 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 27cc6ea...851799d. Read the comment docs.

norbusan commented 4 years ago

This is very specific to using homebrew while ignoring other ways to install Java on MacOS (macports, direct package, ...), thus, this is not really helpful as is.

Furthermore, I don't think that explanation how to manage multple Java versions using jenv are useful here, we don't do it either for Windows nor Linux.

blossom2017 commented 4 years ago

Ok closing it.