resolving issues #1408 - Githubissues

fossasia / susi_server

SUSI.AI server backend - the Artificial Intelligence server for personal assistants https://susi.ai

GNU Lesser General Public License v2.1

2.5k stars 1.08k forks source link

resolving issues #1408 #1475

Closed Lucifer0x17 closed 3 years ago

Lucifer0x17 commented 3 years ago

Fixes #[Add issue number here. If you do not solve the issue entirely, please change the message e.g. "First steps for issues #IssueNumber]

Changes: [Add here what changes were made in this issue and if possible provide links.]

@Dilshaad21 Can you please check and let me know?

lgtm-com[bot] commented 3 years ago

This pull request introduces 17 alerts when merging fca86339518c82cf91a161595b59a04a73980772 into fe8b0ac8cc4e8316f024fd8c3994b9c7464fe78a - view on LGTM.com

new alerts:

8 for Missing variable declaration
5 for Unused variable, import, function or class
3 for Use of AngularJS markup in URL-valued attribute
1 for Malformed id attribute

norbusan commented 3 years ago

Sorry, this PR is completely bogus out of many reasons:

PR needs to be done against the development branch
this PR does not move the html files, it just adds copies of them
it does not guarantee that the susi server finds the files and building and deployment works

The issue clearly states

Move /html folder to /src/html and update any dependencies

that is not copy all files, and the dependencies need to be fixed, too. Furthermore, making sure that it works is integral part of it.

I leave it up to @Orbiter but I would close the PR straight away.

Lucifer0x17 commented 3 years ago

@norbusan Can you explain a little. I'm new to open source so it's little confusing.

mariobehling commented 3 years ago

@Lucifer0x17 I recommend you take up an easier issue to start with. We do not have the bandwidth to teach all the steps to resolve this issue unfortunately. Thanks for your interest. Hope to see you continuing your first steps in FOSS! Thank you.

Lucifer0x17 commented 3 years ago

okay! @mariobehling Thanks for your support.