Closed da-h closed 2 years ago
Quick question on the suggestion for improvement: what do you mean exactly? Only resource I can find is the use of ${{ failure() }}
in an action to save build failure logs. I am somewhat at a loss here. :sweat_smile:
To some degree I'm not sure if it would already happen (that the action would display a failure) if you were to make a mistake. Can be tested by putting a package that doesn't exist into the package.json
(to test npm install
) and then making an unparsable syntax error in the js code (to test npm run build
).
Indeed, this is the case. I just double checked this for both mentioned scenarios:
Description
This PR moves the requirement to commit build files from the contributor to a dedicated github action.
Motivation and Context
The goal of this PR is to ensure consistency across builds on the one hand, and to increase security of the deployment on the other hand.
How Has This Been Tested?
See the action result in my own test branch
Notes
The new action triggers on any pushes of the
js/**
files. Alternatively, it would be reasonable to eithermaster
onlyTypes of changes
Checklist: