fossasia / visdom

A flexible tool for creating, organizing, and sharing visualizations of live, rich data. Supports Torch and Numpy.
Apache License 2.0
10.04k stars 1.13k forks source link

github-actions: adapt cypress test to new server code #880

Closed da-h closed 2 years ago

da-h commented 2 years ago

Description

This PR adapts the cypress test workflow to the new server code (for future reference: #858). Note that it removes the additional checks introduced in #858 (commit 1a34bb6b) to have the test work across the different versions for the server (before and after refactoring).

(The test failed here because of a missing argument for test. It should have been if test -f "py/visdom/server.py" instead of if test "py/visdom/server.py". Nevertheless, the extra test-case here is not required anymore.)

How Has This Been Tested?

Tested on my own fork, see here

Types of changes

Checklist:

da-h commented 2 years ago

Added a commit to let all tests use the visdom command instead of the "local" call python3 py/visdom/server. (The ./github/actions/prepare/action.yml installs the packages anyways before any test.)

JackUrb commented 2 years ago

Fair point - the single file script was able to avoid install, but too unwieldy to continue to maintain. I think the tradeoff is worthwhile.