Closed da-h closed 2 years ago
Added a commit to let all tests use the visdom
command instead of the "local" call python3 py/visdom/server
.
(The ./github/actions/prepare/action.yml
installs the packages anyways before any test.)
setup.py
installed package visdom
. I.e. running python3 py/visdom/server
will not work if the code has not been installed.Fair point - the single file script was able to avoid install, but too unwieldy to continue to maintain. I think the tradeoff is worthwhile.
Description
This PR adapts the cypress test workflow to the new server code (for future reference: #858). Note that it removes the additional checks introduced in #858 (commit 1a34bb6b) to have the test work across the different versions for the server (before and after refactoring).
(The test failed here because of a missing argument for
test
. It should have beenif test -f "py/visdom/server.py"
instead ofif test "py/visdom/server.py"
. Nevertheless, the extra test-case here is not required anymore.)How Has This Been Tested?
Tested on my own fork, see here
Types of changes
Checklist:
py/visdom/VERSION
according to Semantic Versioning