Cypress Tests for Env Modal & View Modal - Githubissues

fossasia / visdom

A flexible tool for creating, organizing, and sharing visualizations of live, rich data. Supports Torch and Numpy.

Apache License 2.0

9.93k stars 1.13k forks source link

Cypress Tests for Env Modal & View Modal #886

Closed da-h closed 1 year ago

da-h commented 1 year ago

Description

Cypress test has been missing two important features of visdom: env-forking and view-saving. This PR adds some simple tests for these features.

Motivation and Context

I am currently splitting the main.js-file into sub-components / separate files and needed a way to check those features automatically.

Note

During testing I found two bugs related to the view:

One cannot remove envs if they are not saved. Visdom server just crashes if one presses the delete button.
When removing an env, its windows do not disappear.

I've added a issue for this and also included the non-working tests as a comment in case someone solves the issue someday. :)

Types of changes

[x] Test cases added
[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactor or cleanup (changes to existing code for improved readability or performance)

Checklist:

[ ] I adapted the version number under py/visdom/VERSION according to Semantic Versioning
[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.