Open Aryanamish opened 1 year ago
Hm I'm unsure why the tests are failing here, it may be a good idea to rebase then regen the minified frontend.
Great bugfix!
As a side-note:
I fixed the linting error
The failing of the functional test seems legitimate to me: This PR in its current form does not work for forked environments.
Reason is that the state of each window does not yet adapt to the new eid
when forking. (See https://github.com/fossasia/visdom/blob/master/py/visdom/server/handlers/web_handlers.py#L472).
I.e. the windows are stored under the forked eid
, however the windows (local) state contain the eid
the windows belong as well, which has not been adapted, yet.
The Python Linter-Error can be fixed easily.
The visual regression tests: see update below.
Regarding the other failing tests:
Best, da-h
Update:
I've checked the visual regression test, which is legitimately failing as well:
For instance the end-state for the test compare_plot_line_multiple
looks like this:
but should contain this compare plot:
Updated the backend to send the environment ID with the render information.
Updated the Front End to ignore the incoming window when it is not in the currently selected environment
Motivation and Context
issue #80
Types of changes
Checklist:
py/visdom/VERSION
according to Semantic Versioning