Test for complete property update & fix the test `property_callback` - Githubissues

fossasia / visdom

A flexible tool for creating, organizing, and sharing visualizations of live, rich data. Supports Torch and Numpy.

Apache License 2.0

9.93k stars 1.13k forks source link

Test for complete property update & fix the test `property_callback` #899

Closed da-h closed 1 year ago

da-h commented 1 year ago

Description

This PR applies two small changes to the testing-setup:

It adds some simple checks to test if properties in a PropertyPane are updated after a user-input.
Also fixing the respective test property_callback. The test did not update the properties correctly; it did write the changes, but to another env.

Motivation and Context

-

How Has This Been Tested?

-

Screenshots (if appropriate):

-

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Code refactor or cleanup (changes to existing code for improved readability or performance)

Checklist:

[ ] I adapted the version number under py/visdom/VERSION according to Semantic Versioning
[x] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.