search

fossasia / visdom

A flexible tool for creating, organizing, and sharing visualizations of live, rich data. Supports Torch and Numpy.
Apache License 2.0
9.99k stars 1.14k forks source link

Is it possible to integrate the `static` folder into the installation package? #907

Open KarhouTam opened 1 year ago

KarhouTam commented 1 year ago

Is your feature request related to a problem? Please describe. It's hard for me to download scripts for the first time of launching visdom. Errors http.client.IncompleteRead and http.client.RemoteDisconnected are always around me, whether my network is behind proxy or not. I have checked my network connection and can't find any problems. 

Describe the solution you'd like Integrate all scripts visdom needs to the installation package.

Describe alternatives you've considered Offer the downloaded static on Github according to the visdom version for easy download.

Additional context Add any other context or screenshots about the feature request here.

da-h commented 1 year ago

Hey @KarhouTam,

I am not sure about putting the static files into the PyPI/pip-release. I guess, one would have to check if the licenses of the respective projects that are downloaded are compatible with such a repackaging.

However, I imagine this should be possible for, say, a conda-environment. I'll check the conda-forge documentation if this is allowed with their packages and if yes, push a PR to https://anaconda.org/conda-forge/visdom.

Best da-h

KarhouTam commented 1 year ago

Thanks for your reply. If pre-downloaded static files are integrated in the conda package of visdom, that will make much convenience to me. Again, thanks a lot!

---Original--- From: "David @.> Date: Sat, Mar 4, 2023 23:41 PM To: @.>; Cc: "Jiahao @.**@.>; Subject: Re: [fossasia/visdom] Is it possible to integrate the static folderinto the installation package? (Issue #907)

Hey @KarhouTam,

I am not sure about putting the static files into the PyPI/pip-release. I guess, one would have to check if the licenses of the respective projects that are downloaded are compatible with such a repackaging.

However, I imagine this should be possible for, say, a conda-environment. I'll check the conda-forge documentation if this is allowed with their packages and if yes, push a PR to https://anaconda.org/conda-forge/visdom.

Best da-h

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you were mentioned.Message ID: @.***>

da-h commented 1 year ago

~I just found another neat solution, which is using js-pip-packages such as the javascript-packages of the Fantastic team.

Using these would solve the problem for both, pypi-package users and conda users.~

Edit: This solution does not work; Only few of the libraries required for visdom are managed by fantastic team. The others are unfortunately not up-to-date or not present on pypi.

da-h commented 1 year ago

I am not sure about putting the static files into the PyPI/pip-release. I guess, one would have to check if the licenses of the respective projects that are downloaded are compatible with such a repackaging.

Just checked all licenses in the static-folder. As far as I can tell, all projects used would allow packaged redistribution when providing their original LICENSE file with the code. Glyphicons-Halflings additionally requires attribution.

KarhouTam commented 1 year ago

I think that's a positive sign? Anticipate it 👀.