Improve/Correct Settings page

fossasia / wp-tweets-widget

Latest Tweets Widget Wordpress Plugin

https://wordpress.org/plugins/tweets-widget/

1.5k stars 6 forks source link

Improve/Correct Settings page #13

Open mariobehling opened 8 years ago

mariobehling commented 8 years ago

screenshot from 2016-08-27 15 50 18

[x] Change "API Authentication Settings" to "Tweets Widget Settings"
[x] Change "Twitter application not fully configured" to "Twitter API not configured. Details are available in your Twitter dashboard. The plugin is still functional if you use the loklak.org API."
[ ] Do not use "h3" for "Twitter API not configured..." area. Just keep the background style as is, but just use normal paragraph text.
[x] Change settings page from options-general.php?page=twitter-api-admin' totweets-widget-settings`
[x] On Sidebar change "Twitter API" to "Tweets Widget"

sopankhosla commented 8 years ago

All these settings are defined in the api @ 9ddd9ad. I would have to change the API somewhat to make the changes. Removing the api as a gitmodule and including the code directly. @mariobehling

mariobehling commented 8 years ago

I would have to change the API somewhat to make the changes.

So, the ticked points are done and only for the remaining point you need to implement the changes?

Just do first what is easy and then the other things step by step.

Release early and often. So, after you changed it, feel free to make another release.

sopankhosla commented 8 years ago

For all the 5 points I would have to make the changes in the API. I have done the four ticked changes.

The style: "H3" is basically a style for error messages, I will have make WP treat this as a non-error message. I will see what can be done. @mariobehling

mariobehling commented 8 years ago

"H3" is basically a style for error messages

Ah ok. Well, it is not an error anymore as the app works now also without that thing. But I like the white background and red vertical line on the left. To keep something like that would be nice.