search

fossasia / wp-tweets-widget

Latest Tweets Widget Wordpress Plugin
https://wordpress.org/plugins/tweets-widget/
1.5k stars 6 forks source link

Discuss the UI where loklak API would appear as an option #6

Closed sopankhosla closed 8 years ago

sopankhosla commented 8 years ago

Currently I have added the option in widgets appearance page. selection_003 Please suggest what else would be better.

mariobehling commented 8 years ago

These kind of options are usually in the Settings section.

mariobehling commented 8 years ago

Please add here

screenshot from 2016-06-05 14 11 59

sopankhosla commented 8 years ago

@mariobehling I would also like to ask the creator of that plugin on how he wants the UI to be. I am putting this as a PR to the original repo.

mariobehling commented 8 years ago

@sopu We can discuss for a long time or get some code done. It is unsure, if the creator agrees at all with adding loklak and feedback might take a long time. Please let's progress and get some code done. It would be good to have loklak as a global option in the settings as well.

sopankhosla commented 8 years ago

@mariobehling the settings page is rendered from a submodule (https://github.com/timwhitlock/wp-twitter-api/tree/9ddd9adc5fea2568b67d2e96326f4b2d7f847551). To add globally to settings page, we would have to tweak that submodule. And then connect it to the widget.

mariobehling commented 8 years ago

@sopu Yes, I know. Please proceed. We need this one or the other way. We could later also use that module without twitter. So we definitely need that part to get done.

sopankhosla commented 8 years ago

The final UI as decided is selection_005

sopankhosla commented 8 years ago

Closing issue!