search

fossfreedom / alternative-toolbar

Modern, minimal and music-focused interface for Rhythmbox
GNU General Public License v3.0
157 stars 20 forks source link

Show app restart info dialog when plugin is disabled #156

Closed crvigh closed 3 years ago

crvigh commented 4 years ago

Closes: #154 #153

We don't do a application restart due to https://github.com/fossfreedom/alternative-toolbar/issues/155

fossfreedom commented 4 years ago

many thanks! From a quick glance all looks ok to me.

I've got a few things to-do - but will test soonish before merging.

crvigh commented 4 years ago

Actually the plugin doesn't need to perform any UI modifications in do_deactivate(), now that the user has been notified. It will be much cleaner and usable that way, even if the user wishes to continue with the current UI, until he chooses to restart.

And it would make sense to do the same when enabling the plugin as well, so it would be consistent from the user's point of view.

Please take care of the modifications.

crvigh commented 4 years ago

It will be much cleaner and usable that way, even if the user wishes to continue with the current UI, until he chooses to restart. And it would make sense to do the same when enabling the plugin as well, so it would be consistent from the user's point of view.

Caused by disabling plugin in Xubuntu 20.04

alternative-toolbar-disable-bug